Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mysql raw query action #11994

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

bizyb
Copy link
Contributor

@bizyb bizyb commented May 17, 2024

WHY

Copy link

vercel bot commented May 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Ignored (Inspect) Visit Preview May 17, 2024 8:58pm
pipedream-docs ⬜️ Ignored (Inspect) May 17, 2024 8:58pm
pipedream-docs-redirect-do-not-edit ⬜️ Ignored (Inspect) May 17, 2024 8:58pm

@pipedream-component-development
Copy link
Collaborator

Thank you so much for submitting this! We've added it to our backlog to review, and our team has been notified.

@pipedream-component-development
Copy link
Collaborator

Thanks for submitting this PR! When we review PRs, we follow the Pipedream component guidelines. If you're not familiar, here's a quick checklist:

@bizyb bizyb requested a review from jverce May 17, 2024 17:51
Copy link
Collaborator

@jcortes jcortes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @bizyb thanks for your contribution but I would like to know what you want to achieve? I noticed you are adding a new prop named sql with type sql but I'm afraid we don't support it. For more info on types you can take a look at https://pipedream.com/docs/v2/components/api/#user-input-props so let me know if you have any questions about it, thanks in advance!

jverce
jverce previously approved these changes May 17, 2024
@bizyb
Copy link
Contributor Author

bizyb commented May 17, 2024

Hi @bizyb thanks for your contribution but I would like to know what you want to achieve? I noticed you are adding a new prop named sql with type sql but I'm afraid we don't support it. For more info on types you can take a look at https://pipedream.com/docs/v2/components/api/#user-input-props so let me know if you have any questions about it, thanks in advance!

Hi @jcortes, I'm a Pipedream staff developer. The sql prop is a new feature that was released recently and is in development. My changes will allow us to to do e2e validation of the sql feature.

Copy link
Collaborator

@jcortes jcortes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarification @bizyb lgtm!

@bizyb bizyb added blocked Issue is blocked pending a resolution DO NOT MERGE labels May 20, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed offline, we need to adapt the this.sql prop to the format that this.mysql.executeQuery expects:

const args = this.mysql.executeQueryAdapter(this.sql);
return this.mysql.executeQuery(args);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Issue is blocked pending a resolution DO NOT MERGE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants