-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update mysql raw query action #11994
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Ignored Deployments
|
Thank you so much for submitting this! We've added it to our backlog to review, and our team has been notified. |
Thanks for submitting this PR! When we review PRs, we follow the Pipedream component guidelines. If you're not familiar, here's a quick checklist:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @bizyb thanks for your contribution but I would like to know what you want to achieve? I noticed you are adding a new prop named sql
with type sql
but I'm afraid we don't support it. For more info on types you can take a look at https://pipedream.com/docs/v2/components/api/#user-input-props so let me know if you have any questions about it, thanks in advance!
Hi @jcortes, I'm a Pipedream staff developer. The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for clarification @bizyb lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed offline, we need to adapt the this.sql
prop to the format that this.mysql.executeQuery
expects:
const args = this.mysql.executeQueryAdapter(this.sql);
return this.mysql.executeQuery(args);
WHY