Auth: fix a crash and some cleanup in the auth-catalogzone.cc

[mind04]

Short description

An incomplete SOA record like ns.example.com mail.example.com 1 in a producer zone resulted in termination of the communicator thread.

Checklist

I have:

• read the CONTRIBUTING.md document
• compiled this code
• tested this code
• included documentation (including possible behaviour changes)
• documented the code
• added or modified regression test(s)
• added or modified unit test(s)

[coveralls]

Pull Request Test Coverage Report for Build 9418798096

Details

• 23 of 50 (46.0%) changed or added relevant lines in 4 files are covered.
• 45 unchanged lines in 14 files lost coverage.
• Overall coverage increased (+0.002%) to 64.612%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pdns/backends/gsql/gsqlbackend.cc	1	5	20.0%
modules/lmdbbackend/lmdbbackend.cc	0	5	0.0%
pdns/auth-catalogzone.cc	22	31	70.97%
pdns/auth-primarycommunicator.cc	0	9	0.0%

Files with Coverage Reduction	New Missed Lines	%
modules/lmdbbackend/lmdbbackend.hh	1	90.0%
pdns/backends/gsql/gsqlbackend.cc	1	81.88%
pdns/recursordist/sortlist.cc	2	72.94%
pdns/recursordist/aggressive_nsec.cc	2	66.17%
pdns/misc.cc	2	63.35%
pdns/recursordist/test-syncres_cc2.cc	3	88.91%
pdns/dnsdistdist/dnsdist-carbon.cc	3	61.82%
modules/lmdbbackend/lmdbbackend.cc	3	73.5%
pdns/recursordist/rec-main.cc	3	61.68%
modules/gpgsqlbackend/spgsql.cc	3	67.7%

Totals
Change from base Build 9416932620:	0.002%
Covered Lines:	124373
Relevant Lines:	161708

---

💛 - Coveralls

[Habbie]

one question; will do a full review later

[Habbie]

nice cleanup :) I left a few comments. Also, clang-tidy is unhappy about your short ci and di variable names (you can see this in the Files view or https://github.com/PowerDNS/pdns/actions/runs/8660761587)