-
Notifications
You must be signed in to change notification settings - Fork 883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow setting notify_allowed in Recursor API for forwarded zones #14121
Conversation
Hello, thanks for the PR. I'm wondering about the old config case. I do not see the code that handles notify_allowed for that. I'll try to test soon. |
I was misdiagnosing earlier, there is code to handle notify, also for old-style configs. |
Pull Request Test Coverage Report for Build 9265491441Details
💛 - Coveralls |
Thanks @omoerbeek! I compiled and tested with your change, that is very helpful. One last thing I was wondering, should we also add the
Please let me know if there is anything I need to do for this. |
a103b6d
to
6cf2966
Compare
Added simple test and rebased. |
Closes #14116
Short description
Allows setting
notify_allowed
when adding forwarded zones through the Recursor API. This works with the new YAML settings and the old-style settings. Ifnotify_allowed
is not sent or is set to false, the behavior is unchanged. Ifnotify_allowed
is set to true the Recursor will allow NOTIFY to clear cache for the given zone.Checklist
I have: