Support meson in regression tests harness #14183
Merged
+119
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredmorcos
force-pushed
the
auth-regression-tests-meson
branch
from
44db47f
to
65ea611
Compare
Pull Request Test Coverage Report for Build 9480790598Details
💛 - Coveralls |
Habbie
approved these changes
May 17, 2024
|
at least one thing failed https://github.com/PowerDNS/pdns/actions/runs/9112492048/job/25051863344#step:13:626 |
That was supposed to be part of the other PR which added some logging for backend loading. It's already merged and the loglevels got in here by accident. I want to keep them if that's OK for you.
I'll look into it. The failure makes sense, but what doesn't is why it didn't fail before. |
fredmorcos
force-pushed
the
auth-regression-tests-meson
branch
3 times, most recently
from
1e90254
to
955c9f8
Compare
Habbie
approved these changes
Jun 10, 2024
romeroalx
requested changes
Jun 10, 2024
There was a problem hiding this comment.
We just reviewed this PR with @fredmorcos and he will make a minor change. Adding this comment to prevent an accidental merge.
romeroalx
approved these changes
Jun 10, 2024
fredmorcos
force-pushed
the
auth-regression-tests-meson
branch
from
9619e13
to
acd67e5
Compare
This also ensures that PDNS_BUILD_PATH is set to `.` when the user does not pass it. This stays consistent with the behavior we previously had.
fredmorcos
force-pushed
the
auth-regression-tests-meson
branch
from
acd67e5
to
3ee4a89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Adds meson support into the auth backend regression tests harness.
The CI parts are still missing and I'll add them in a later PR, they're quite the headache for now.
Checklist
I have: