-
Notifications
You must be signed in to change notification settings - Fork 755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
better usability for deletelink #268
base: master
Are you sure you want to change the base?
Conversation
better usability for deletelink
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ukcb,
thanks for your first contribution to this project! 🎉 👍
I hope you'll like this project and can enjoy hacking on it… 😃
So with your change the delete link is very bright and yellow now…
I like that it is more obvious/visible now, but maybe it is a bit too much in this yellow/red thing, which does not really fit into the overall design.
Maybe better try to use a button design Bootstrap already provides: https://v4-alpha.getbootstrap.com/components/buttons/
Then you may also not need much CSS, but just add some classes from Bootstrap to the template or so.
Keep in mind to not make the button to bright. We do not want to encourage users to accidentally click on it or so.
Also, BTW, as per our editorconfig please intend CSS files with tabs instead of spaces.
Good idea, @rugk. How about adding one of the following, existing classes to the link:
|
Yeah, why not? @ukcb so could you try that out? |
Yeah you can manually add a margin though and change the text-color so it is readable. |
@ukcb Are you still interested in it? If not, that's no problem, just add a notice, so I know what the current status of this issue is. |
only a small change
Edit by @rugk: Fixes #266