New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runcommand: do not replace %ROM% or %ROM_BN% tokens when empty #3551

Open

twojstaryzdomu wants to merge 1 commit into RetroPie:master from twojstaryzdomu:runcommand_tokens

twojstaryzdomu commented Jun 14, 2022 •

edited

Empty %ROM% tokens will cause parameter issues for binaries that do not handle empty quoting without a parameter.

In some circumstances this makes sense - the binary has a sensible %ROM% default when empty.

Think empty %ROM% = game runs as default, %ROM% provided = user picked a custom level.

This PR addresses #3550.


          Do not replace tokens when empty

e127987

twojstaryzdomu changed the title ~~Do not replace tokens when empty~~ runcommand: do not replace %ROM% or %ROM_BN% tokens when empty

twojstaryzdomu mentioned this pull request

runcommand.sh: do not replace %ROM% tokens when empty #3550

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment