fix: OTR conversation closes automatically when any of the peers goes offline

[KevLehman]

Proposed changes (including videos or screenshots)

Issue(s)

https://rocketchat.atlassian.net/browse/SUP-447

Steps to test or reproduce

Fixes #7974

Further comments

The fix involves adding a listener to user presence in 2 places:

• On acknowledge (this is, the user that starts the OTR session after the other party clicks on "yes" to start OTR)
• On stablishment (the user clicking on "yes" on the modal)

This will allow any of the parties to end the session when the other party goes offline.
This will also trigger when one of the parties logs out.

When one of the involved user logs out, we'll clear the instancesByRoomId object. This will allow the user to login to a clean sheet and open any OTR conversation again (after a refresh, but this is caused by another bug).

[changeset-bot]

⚠️ No Changeset found

Latest commit: 0a569cc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[dionisio-bot]

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

[codecov]

Codecov Report

Attention: Patch coverage is 22.72727% with 17 lines in your changes missing coverage. Please review.

Project coverage is 56.33%. Comparing base (3d74b63) to head (0a569cc).

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #32430      +/-   ##
===========================================
- Coverage    56.35%   56.33%   -0.03%     
===========================================
  Files         2433     2438       +5     
  Lines        53765    53846      +81     
  Branches     11090    11103      +13     
===========================================
+ Hits         30301    30333      +32     
- Misses       20852    20865      +13     
- Partials      2612     2648      +36     

Flag	Coverage Δ
e2e	56.04% <22.72%> (-0.06%)	⬇️
unit	71.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

[yash-rajpal]

LGTM!