feat: E2EE room setup header #32446
Open
feat: E2EE room setup header #32446
+121
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd restoring commented test
hugocostadev
previously approved these changes
May 20, 2024
MarcosSpessatto
requested changes
Jun 11, 2024
Comment on lines
+2
to
+3
| '@rocket.chat/i18n': patch | ||
| '@rocket.chat/meteor': patch |
There was a problem hiding this comment.
Suggested change
| '@rocket.chat/i18n': patch | |
| '@rocket.chat/meteor': patch | |
| '@rocket.chat/i18n': minor | |
| '@rocket.chat/meteor': minor |
| @@ -18,6 +19,9 @@ type HeaderProps<T> = { | |||
|
|
|||
| const Header = ({ room }: HeaderProps<IRoom>): ReactElement | null => { | |||
| const { isMobile, isEmbedded, showTopNavbarEmbeddedLayout } = useLayout(); | |||
| const encrypted = Boolean(room.encrypted); | |||
| const unencryptedMessagesAllowed = useSetting('E2E_Allow_Unencrypted_Messages'); | |||
There was a problem hiding this comment.
Suggested change
| const unencryptedMessagesAllowed = useSetting('E2E_Allow_Unencrypted_Messages'); | |
| const unencryptedMessagesAllowed = useSetting<boolean>('E2E_Allow_Unencrypted_Messages'); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new Header for the E2EE room setup flow, idea is that we shouldn't show all the room actions on the setup window and only a few items makes sense to be kept on this Header.
This PR introduces a new E2EERoomHeaderToolbox which is a toolbox for this specific use-case which contains only 3 room actions, e2e, room-info and members tab.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
E2EE-27