New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WindowBase::setImePreEditPosition #2469
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small note: we generally use PascalCase for abbreviations (Utf
, UdpSocket
, Http
, AlResource
).
This would mean IMEPreeditPosition
should be ImePreeditPosition
.
(Strictly speaking, WindowImplDRM
is also not consistent, but that's out of scope for this PR).
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2469 +/- ##
==========================================
- Coverage 38.54% 38.49% -0.05%
==========================================
Files 229 229
Lines 19806 19834 +28
Branches 4733 4737 +4
==========================================
+ Hits 7635 7636 +1
- Misses 11147 11243 +96
+ Partials 1024 955 -69
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Issues fixed and rebased to latest master. |
Is preedit really the most commonly referred to name for that window? If we stick with preedit, I suggest to use PR needs to be rebased |
e04bcbb
to
5e9c13c
Compare
Rebased to latest master. I won't prefer the word 'Composition'. Please correct me if I'm wrong, but in my understanding the word more describes the use of the Compose key to combine accent marks with Latin alphabet in some European languages. IMEs are something quite different. People around me call that window something like 'input method window' or '(input method) selection pending box'. I'm from China mainland btw. |
Description
This PR adds a method to
WindowBase
,setImePreEditPosition(const Vector2i& pos)
, that hints to the OS/IME framework where to put the preedit window.Tasks
I'm completely illiterate when it comes to macOS/Objective-C (or any other Apple stuff), and I need help on that part.
How to test this PR?
Install an IME if you don't have one, and run this example.
This is relatively straightforward on Windows 10: install a language of Chinese Simplified/Traditional or Japanese in the Settings app, and press Win+Space to switch to that input.
Click around in the opened window, and try typing with the IME engaged.