Test for correct network ordering of packets #2562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2562 +/- ##
==========================================
+ Coverage 27.18% 27.29% +0.11%
==========================================
Files 227 227
Lines 19701 19701
Branches 4747 4747
==========================================
+ Hits 5355 5377 +22
+ Misses 13887 13577 -310
- Partials 459 747 +288 see 54 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
binary1248
approved these changes
May 21, 2023
Bambo-Borris
approved these changes
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We were previously testing for round-trip correctness after serialization and deserialization but we were not testing that the serialized forms matches network order. It's a safe assumption that all of our development machines and CI runners are Little Endian so these tests won't be truly meaningful until we can run on Big Endian hardware. Given how rare BE hardware is, arguably it doesn't even matter whether we honor network ordering but as it stands now, the API promises as such so it's a good idea to test it.
These tests will give us more feedback on the changes made in #2380.