[Vehicules / Modification Feature] Meilleure entrée pour les portes des véhicules. #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For metrics for unemployed crimi player, set job as crimi
…-passager Loop correctly on all seats when search dead to extract
…er-category Use different metric for transform and craft for FFS
…-on-clean Fix clear house stash on house clean
…nd-without-phone Fix launch end call sound on missing call only if phone available
feat(vehicle): put hard limit on boat to not explode when coming out of garage
fix(vehicle): apply perf after condition, avoid over repair
…gration_discord [DISCORD] Update l'intégration Discord à 350 joueurs max
Ajoutr de Ferme de Fou
…amer-tag Admin when displaying gamer tag, do not display self one
….spawner.ts Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Fix vandalism alert generated server side
…c-decrease-foundry-electricity-comsumption Decrease DMC foundry electricity comsumption
Fix Quality Icon
- job_upw_station_restock event not correctly generated when using last cell if the type in inventory - Remove error log when a player that is not the owner or the roommate use a house garage, for exemple when he received key for owner or the roommate - Fix gun shot alert - Fix server error log when calling someone alreasy in call - Fix error messages for phone - When adding a tetris score update imemory leaderboard instead of recreating it when DB which is costly
…mp explicitly in SQL for SMS
Fix errors found in server logs
…-message omxsql badly handle TZ diff between DB and client, so request timestamp explicitly in SQL for SMS
…ncel-setting-armor Cancel armor suit up on animation cancel
Increase number of seats and fix bugs with bus fix seat index & add more seats fix(vehicle doors): better determine vhl entry door with native GetEntryPositionOfDoor
|
testé et validé ✅ |
|
PR reporté sur le répo principal ! Merci à toi pour la contribution ❤️ |
joelwurtz
pushed a commit
that referenced
this pull request
Dec 4, 2023
From #283 By Zocaxu Increase number of seats and fix bugs with bus fix seat index & add more seats fix(vehicle doors): better determine vhl entry door with native GetEntryPositionOfDoor
joelwurtz
pushed a commit
that referenced
this pull request
Dec 5, 2023
From #283 By Zocaxu Increase number of seats and fix bugs with bus fix seat index & add more seats fix(vehicle doors): better determine vhl entry door with native GetEntryPositionOfDoor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR pour l'issue #273
Je tire parti de la native
GetEntryPositionOfDoorqui est efficace pour les 4 premiers sièges des véhicules. Elle permet d'avoir une meilleure position d'entrée du ped.Pour les sièges dit "extra" (au delà de 4), j'utilise les bones des pneus arrière, comme fait actuellement sur SOZ. L'expérience montre que cela fonctionne bien et cause le moins de bugs.
Je mets les motos appart pour éviter qu'un joueur monte à l'arrière si la position de conducteur est libre.
J'en profite également pour rajouter plus de sièges extra, jusqu'à 12, pour pouvoir monter à beaucoup dans les bus par exemple.
Je propose une liste d'exclusion pour les véhicules qui se comportent mal avec cette native, en restaurant l'ancien comportement pour ces derniers (il y en a très peu).