Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appdata: translate=no properties #291

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

yakushabb
Copy link
Contributor

It appears that the appstream project no longer supports translatable=no properties, and gettext extract the translatable=no marked strings as translatable.

I opened an issue to inform about the situation, but translatable=no properties are not accepted by developers. You can find the issue here: https://github.com/ximion/appstream/issues/623

Please test your script or string extraction process before merging this PR.

In MetaInfo files, each individual paragraph of a description
(or enumerated entry) is translated individually, however,
you can only exclude the complete block from being translated
by adding translate="no" to the description element.

Source: https://freedesktop.org/software/appstream/docs/sect-Quickstart-Translation.html

It appears that the appstream project no longer supports
`translatable=no` properties, and gettext extract the
`translatable=no` marked strings as translatable.

I opened an issue to inform about the situation, but `translatable=no`
properties are not accepted by developers. You can find the issue
here: `ximion/appstream#623

**Please test your script or string extraction process before merging this PR.**

> In MetaInfo files, each individual paragraph of a description
> (or enumerated entry) is translated individually, however,
> you can only exclude the complete block from being translated
> by adding `translate="no"` to the description element.

Source: https://freedesktop.org/software/appstream/docs/sect-Quickstart-Translation.html
@SeaDve
Copy link
Owner

SeaDve commented Apr 3, 2024

It seems that the string extraction used by ninja -C _build kooha-pot doesn't recognize it.

@yakushabb
Copy link
Contributor Author

Sorry, what version of gettext installed on your system or test environment?

@SeaDve
Copy link
Owner

SeaDve commented Apr 3, 2024

It returns the following:

bash-5.2$ gettext --version
gettext (GNU gettext-runtime) 0.22

@yakushabb
Copy link
Contributor Author

Could you test with the following its files: https://github.com/ximion/appstream/tree/main/data/its

I tested on my Fedora copying them to /usr/share/gettext/its/ and /usr/share/gettext-0.22.5/its/ directories.

(Please packup original files)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants