-
-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed some redundant exists checks and formatting stuff #6696
Removed some redundant exists checks and formatting stuff #6696
Conversation
I don't think it's safe to remove the AoE cloud handles. They were just added for 1.20.5. |
Oh true. Sorry, I didn't give it much thought honestly coz it was listed in #6641 under the 1.13 bit. I'll revert those changes in a second, but do you know what else the AOE stuff in the legacy tracker issue could be referring to? |
It may be a mistake, I'll check with Sovde |
Too easy, appreciate it. If I just put the stuff I removed back in and then push it here, will it like, cancel out and remove the file from this PR? |
yes this was a mistake, I read it backwards, thinking the method was for newer versions rather than older versions, I'll remove it from the issue checklist |
Yes don't worry Sovde put some things in the list that shouldn't have been 😔 he got me too We can go through it all again at the end anyway in case something was missed |
the ones you crossed off were just for docs updates, not removing checks |
Description
This PR removes some redundant exists checks for BukkitClasses, SimpleEvents and BukkitEventValues.
Target Minecraft Versions: any
Requirements: none
Related Issues: #6676 #6641