Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy Up Failed JUnit Results Print #6700

Merged

Conversation

NotSoDelayed
Copy link
Contributor

@NotSoDelayed NotSoDelayed commented May 17, 2024

Description

This PR tidies up the failed JUnit tests results.

Before: ouch, my eyes squinting, why succeeded test included in failed?!
junit-old

Now: omgg so neat 馃ぉ
junit-new


Target Minecraft Versions: any
Requirements: none
Related Issues: none

@NotSoDelayed NotSoDelayed marked this pull request as draft May 17, 2024 02:23
@NotSoDelayed

This comment was marked as outdated.

@NotSoDelayed

This comment was marked as off-topic.

@NotSoDelayed NotSoDelayed marked this pull request as ready for review May 19, 2024 07:27
@sovdeeth sovdeeth added enhancement Feature request, an issue about something that could be improved, or a PR improving something. unit testing For issues/PRs related to the Skript unit testing system. 2.8 Targeting a 2.8.X version release labels May 30, 2024
@Moderocky Moderocky added the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label May 31, 2024
@sovdeeth sovdeeth added patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. and removed feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. labels May 31, 2024
@Moderocky Moderocky merged commit 129c25d into SkriptLang:dev/patch Jun 1, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.8 Targeting a 2.8.X version release enhancement Feature request, an issue about something that could be improved, or a PR improving something. patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. unit testing For issues/PRs related to the Skript unit testing system.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants