Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Save Command (and tweaks to logging) #4167

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

[Feature] Save Command (and tweaks to logging) #4167

wants to merge 5 commits into from

Conversation

JustAHuman-xD
Copy link
Contributor

@JustAHuman-xD JustAHuman-xD commented Apr 4, 2024 •
edited

Description

Having a save command has been a suggestion for a while and would be useful to server owners/administrators.

Proposed changes

  • will fill once out of draft phase

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • I added sufficient Unit Tests to cover my code.

@github-actions github-actions bot added the 🎈 Feature This Pull Request adds a new feature. label Apr 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 4, 2024

Your Pull Request was automatically labelled as: "🎈 Feature"
Thank you for contributing to this project! ❤️

@JustAHuman-xD
Copy link
Contributor Author

I made this PR in the span of like 5-10 minutes during class so I expect to change lots lol

J3fftw1
J3fftw1 requested changes Apr 4, 2024
View reviewed changes
Copy link
Member

@J3fftw1 J3fftw1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review on the draft

src/main/java/io/github/thebusybiscuit/slimefun4/core/commands/subcommands/SaveCommand.java Outdated Show resolved Hide resolved
src/main/java/io/github/thebusybiscuit/slimefun4/core/services/AutoSavingService.java Outdated
} else {
Slimefun.logger().log(Level.INFO, "Saved all player data for {0} player(s)!", players);
}
Slimefun.logger().log(Level.INFO, "Took {0}ms!", System.currentTimeMillis() - startTime);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice adition

src/main/java/io/github/thebusybiscuit/slimefun4/core/services/AutoSavingService.java Outdated Show resolved Hide resolved
src/main/java/io/github/thebusybiscuit/slimefun4/core/services/AutoSavingService.java Outdated Show resolved Hide resolved
src/main/resources/languages/en/messages.yml Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 9, 2024

Slimefun preview build

A Slimefun preview build is available for testing!
Commit: d2b119c

https://preview-builds.walshy.dev/download/Slimefun/4167/d2b119ca

Note: This is not a supported build and is only here for the purposes of testing.
Do not run this on a live server and do not report bugs anywhere but this PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J3fftw1 J3fftw1 J3fftw1 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
🎈 Feature This Pull Request adds a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JustAHuman-xD @J3fftw1