Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added TestSoundService #4180

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added TestSoundService #4180

wants to merge 1 commit into from

Conversation

Intybyte
Copy link

@Intybyte Intybyte commented May 3, 2024

Description

Unit tests for new sound system

Proposed changes

Adding unitest

Related Issues (if applicable)

Resolves #3881, #2844, #3880

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • I added sufficient Unit Tests to cover my code.

@Intybyte Intybyte requested a review from a team as a code owner May 3, 2024 16:00
Copy link
Contributor

github-actions bot commented May 3, 2024

Pro Tip!
You can help us label your Pull Requests by using the following branch naming convention next time you create a pull request. ❤️

Branch naming convention Label
feature/** 🎈 Feature
fix/** ✨ Fix
chore/** 🧹 Chores
api/** 🔧 API
performance/** 💡 Performance Optimization
compatibility/** 🤝 Compatibility

If your changes do not fall into any of these categories, don't worry. You can just ignore this message in that case! 👀

@J3fftw1
Copy link
Member

J3fftw1 commented May 4, 2024

Thanks for your first PR thank you for reviewing it.

@J3fftw1
Copy link
Member

J3fftw1 commented May 10, 2024

Does this cover all of the soundservice?

Copy link
Contributor

Slimefun preview build

A Slimefun preview build is available for testing!
Commit: 03aa31c

https://preview-builds.walshy.dev/download/Slimefun/4180/03aa31c8

Note: This is not a supported build and is only here for the purposes of testing.
Do not run this on a live server and do not report bugs anywhere but this PR!

@Intybyte
Copy link
Author

Does this cover all of the soundservice?

It should, I get all the element in the SoundEffect enum and check if it has a configuration using the SoundService, as it might be null even if it should not.

In fact the SoundEffect enum has a method that gets the SoundService instance in order to check it, which before returning the value checks if it is null, and prints a warning (the comment itself says that this should not happen in the first place), so by adding this test you are checking all of the elements of SoundEffect ahead in the testing.

It is complete unless the reload method requires some testing too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit tests for new sound system
2 participants