ElectricJuicer #4191
ElectricJuicer #4191
Conversation
Suggestion Slimefun#2560 discord
|
Your Pull Request was automatically labelled as: "🎈 Feature" |
src/main/java/io/github/thebusybiscuit/slimefun4/implementation/SlimefunItems.java
Outdated
Show resolved
Hide resolved
| private static void loadJuicer() { | ||
| List<ItemStack[]> juicerRecipes = new ArrayList<>(); | ||
|
|
||
| Juicer juicer = (Juicer) SlimefunItems.JUICER.getItem(); | ||
| if (juicer == null) { | ||
| return; | ||
| } | ||
|
|
||
| ItemStack[] input = null; | ||
|
|
||
| for (ItemStack[] recipe : juicer.getRecipes()) { | ||
|
|
||
| if (input == null) { | ||
| input = recipe; | ||
| continue; | ||
| } | ||
|
|
||
| if (input[0] != null && recipe[0] != null) { | ||
| juicerRecipes.add(new ItemStack[] { input[0], recipe[0] }); | ||
| } | ||
|
|
||
| input = null; | ||
| } | ||
|
|
||
| Stream<ItemStack[]> stream = juicerRecipes.stream(); | ||
| stream.forEach(recipe -> registerMachineRecipe("ELECTRIC_JUICER", 2, new ItemStack[] { recipe[0] }, new ItemStack[] { recipe[1] })); | ||
| } |
There was a problem hiding this comment.
Not a huge fan with how this works but ill wait to see others opinions
There was a problem hiding this comment.
The only way to load multiblocks recipes into electric machines that I know of is this
|
We previously denied a PR like this since it’s in one of the addons already I think |
|
Oh really? Anyone know what addon? |
Just because an addon adds it it isn't a good reason to not accept the PR man, someone a day made a mod for pistons in minecraft back in beta and mojang decided to add it to the main game. Never saw anyone whining about pistons xD |
|
As a general rule, core slimefun doesn't add items that addons have for obvious reasons. it's not to say it wouldn't happen, but it doesn't make sense to duplicate others work |
|
Can anyone say what addon this is in? If it's abandoned or unmaintained, something like that, I think that'd be justification enough for it being added to core slimefun. |
|
i've not seen one that i can remember. i just checked the active addons and it's not there. the only other juicer i've seen is in fast machines |
Slimefun preview buildA Slimefun preview build is available for testing! https://preview-builds.walshy.dev/download/Slimefun/4191/66d8b392
|
Approved suggestion #2560 discord
Description
Adding an ElectricJuicer so people aren't force to use the manual MultiBlock to get juicer, and can automate the process with cargo.
Proposed changes
Added on PostSetup a juicer recipe loader to a new machine called ElectricJuicer.
The new recipe is similar to the original multiblock, but requiring some electric motors, a battery and some other basic blocks.
Checklist
NonnullandNullableannotations to my methods to indicate their behaviour for null values