GHA: Refactor repetitive action inputs into in-repo composite actions #6199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/L
cognifloyd
commented
May 17, 2024
| @@ -709,6 +594,7 @@ jobs: | |||
| if: always() | |||
| needs: | |||
| - lint-checks | |||
| - self-check | |||
There was a problem hiding this comment.
I noticed that the slack notification can happen before self-check finishes. It turns out, this was missing.
| @@ -122,7 +98,7 @@ jobs: | |||
| - name: Upload Histograms | |||
| uses: actions/upload-artifact@v4 | |||
| with: | |||
| name: benchmark_histograms | |||
| name: benchmark_histograms-py${{ matrix.python-version }} | |||
There was a problem hiding this comment.
This is the line that was causing the microbenchmarks workflow failures. All other instances of actions/upload-artifact were updated/fixed in #6192.
| @@ -214,6 +185,7 @@ jobs: | |||
| - name: Compress Service Logs Before upload | |||
| if: ${{ failure() }} | |||
| run: | | |||
| ./tools/launchdev.sh stop # stop st2 before collecting logs | |||
There was a problem hiding this comment.
I also missed updating this line in #6186. without this, the log compression can fail.
Apparently each action must be in its own folder.
nzlosh
approved these changes
May 21, 2024
rush-skills
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In investigating Microbenchmarks failures, I realized I missed updating one of the keys in #6192.
It has been difficult to keep some of the steps in our GHA workflows consistent with each other. So, this PR tries to simplify at least some of our GHA updates.
The cache actions have the most complex set of inputs, so I refactored them into
compositeactions that can be shared by all of the workflows. I'm loading these actions as local files (The./prefix is required for that), so the repo has to be checked out first before we can use actions like this.Relevant Github docs:
https://docs.github.com/en/actions/creating-actions/creating-a-composite-action
https://docs.github.com/en/actions/creating-actions/metadata-syntax-for-github-actions#runsstepsuses
https://github.com/orgs/community/discussions/26245