Upgrade pantsbuild from 2.18 to 2.20 #6200
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/XL
Lockfile diff: lockfiles/pants-plugins.lock [pants-plugins] == Upgraded dependencies == pantsbuild-pants 2.18.3 --> 2.19.3rc1 pantsbuild-pants-testutil 2.18.3 --> 2.19.3rc1 pex 2.1.137 --> 2.2.1 pluggy 1.4.0 --> 1.5.0 psutil 5.9.0 --> 5.9.8 ujson 5.9.0 --> 5.10.0
This is a new feature in pants 2.19
Lockfile diff: lockfiles/pants-plugins.lock [pants-plugins] == Upgraded dependencies == pantsbuild-pants 2.19.3rc1 --> 2.20.1 pantsbuild-pants-testutil 2.19.3rc1 --> 2.20.1
This is a new feature in pants 2.20
pull-request-size
bot
added
size/L
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commits step through updating from 2.18 to 2.19 to 2.20.
Interesting new features in 2.19
https://www.pantsbuild.org/blog/2024/01/24/pants-2-19
https://github.com/pantsbuild/pants/blob/2.19.x/src/python/pants/notes/2.19.x.md
Pants can auto retry tests to deal with flaky tests in CI. I enabled that in
pants.ci.tomlso it retries a test up to 3x.Interesting new features in 2.20
https://www.pantsbuild.org/blog/2024/03/27/pants-2-20
https://github.com/pantsbuild/pants/blob/2.20.x/src/python/pants/notes/2.20.x.md
Pants can now experimentally use GHA as a remote cache.
Pants has a
pex_binarytarget for generating targets that run a particular entry point or script. Pants 2.20 gained apex_binary(executable=...)field which would allow us to wrap ourst2-*python scripts in a pex at some point. This feature means that pex will embed the script contents instead of attempting to import from a file that is not a valid package name (The "-" character is not valid). For now, I just left a comment in a BUILD file about this.Note: I asked for this feature some time ago. It was first added to pex 2.1.93, and then to pants. Now its available.
pants-plugins lockfile diffs
From 2.18 to 2.19
From 2.19 to 2.20