-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve crypto performance #683
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #683 +/- ##
==========================================
+ Coverage 22.07% 24.73% +2.66%
==========================================
Files 86 90 +4
Lines 8666 9508 +842
Branches 714 850 +136
==========================================
+ Hits 1913 2352 +439
- Misses 6627 7022 +395
- Partials 126 134 +8
Continue to review full report at Codecov.
|
What is this blocked on? |
Merge conflicts, tests, and ideally I'd rather use |
Benchmark:
Benchmark run against a packet about 670 bytes long.
Current code:
This branch:
Unfortunately it seems that about 2/3rds of the CPU time is spent computing the HMAC. I don't think we can do anything about that at the moment.
See also: #552
Some discussion on previous PR at #554.