Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple terminal support on MacOS #507

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

adammathes
Copy link

This is an attempt to enable multiple terminal windows.

Only tested on MacOS but it works for me. Looking for feedback --

  1. Does this work for anyone else and would it be useful?
  2. Does this is approach make sense? I'm new to QT/QML
  3. Is it worth testing/validating on Linux or should it just be limited to MacOS?

@adammathes
Copy link
Author

Oops, this still doesn't quit cleanly. I'll work on it some more before resubmitting.

@adammathes adammathes closed this Feb 10, 2019
@adammathes
Copy link
Author

Turns out the not quitting cleanly behavior is reproducible on the release 1.1.1 build as well, so I'll file an issue separately on that, it doesn't look related to these changes.

@adammathes adammathes reopened this Feb 10, 2019
@Swordfish90
Copy link
Owner

I'd answer yes to all three questions. Linux side, the benefits might be a bit less, but I believe it's still worth it.

The implementation is good, but I think we need some refactoring to take into account multiple windows.

Some items are "singletons" by design, and should be moved to the root element. I think we should only have one ApplicationSettings (which should be the only interface to the db), and only one SettingsWindow and AboutDialog.

If you need some help I can also merge this into a feature branch.

@adammathes
Copy link
Author

Ok, I'll take a pass at trying to do the refactoring and see how far I can get.

Would definitely welcome help on it.

@atmadeep
Copy link

I'd answer yes to all three questions. Linux side, the benefits might be a bit less, but I believe it's still worth it.

The implementation is good, but I think we need some refactoring to take into account multiple windows.

Some items are "singletons" by design, and should be moved to the root element. I think we should only have one ApplicationSettings (which should be the only interface to the db), and only one SettingsWindow and AboutDialog.

If you need some help I can also merge this into a feature branch.

Yes please. I write and run code for robots and computer vision applications. So I use terminator for multiple terminals, but I would really like to have this as my daily driver terminal.

@adammathes
Copy link
Author

Unfortunately I don't have the time to refactor and care for this properly - but I'd encourage someone to merge it into a feature branch and fix it (or just fork this and fix it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants