-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Credits/Shop: Add hooks for credit related events. #1451
Draft
pkillboredom
wants to merge
15
commits into
TTT-2:master
Choose a base branch
from
pkillboredom:20240303-upstream-merge
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 10 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
4ea223b
Add and run new hooks related to credit awards.
pkillboredom 78a95de
Add TTT2OrderedEquipment hook run to sv_shop::RerollShopForCredit
pkillboredom ce275fc
Merge remote-tracking branch 'upstream/master'
pkillboredom ce119b4
Merge remote-tracking branch 'upstream/master' into 20240303-upstream…
pkillboredom 26e3f78
whitespace only changes
pkillboredom df6d3da
Merge commit 'ded4f19fa53f737c223c62f23f05bd1fc971d933' into 20240303…
pkillboredom 265228b
Merge remote-tracking branch 'upstream/master' into 20240303-upstream…
pkillboredom c95331f
Update Changelog.
pkillboredom 97d509c
Add missing realm comments.
pkillboredom 55f2103
Add missing newline in sv_player_ext.lua to satisfy stylua.
pkillboredom 7fb4ee8
Rename hooks and fix missing OnGiveFoundCredits() call (missed that t…
pkillboredom 82d7cb1
Update hook calls with new names
pkillboredom 48224f0
Merge remote-tracking branch 'upstream/master' into 20240303-upstream…
pkillboredom 71d956a
Merge remote-tracking branch 'upstream/master' into 20240303-upstream…
pkillboredom ed62904
Add missing doc comment
pkillboredom File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This hook seems to be called no where?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed in merging from upstream that the place where this was called moved from sv_corpse to bodysearch. I've added the call back and will test sometime in the next few days.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure that adding the additional functionality you've suggested would work for my stats addon, like you said.
The event system currently doesn't have events for the
GM:TTT2OnReceiveKillCredits()
,GM:TTT2OnReceiveTeamAwardCredits()
orGM:TTT2OnTransferCredits()
cases. If you would prefer that I pivot toward using the event system, I think that would work for me over making the hooks cancel-able. I suppose I would just need to add events for those cases and listen to GM:TTT2AddedEvent to record the events in real time, right?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nah, I don't want to pivot you in that direction, I only wanted to make sure that you are aware of it. If you say that it doesn't work for you, then it is fine