ENTITY: New Use workflow #1458
Open
ENTITY: New Use workflow #1458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZenBre4ker
added
type/enhancement
TimGoll
requested changes
Mar 6, 2024
Comment on lines
+63
to
+64
| local client = LocalPlayer() | ||
| if not IsValid(client) or not client:IsTerror() or not self.pickupWeaponClass then |
There was a problem hiding this comment.
Suggested change
| local client = LocalPlayer() | |
| if not IsValid(client) or not client:IsTerror() or not self.pickupWeaponClass then | |
| local client = LocalPlayer() | |
| if not IsValid(client) or not client:IsTerror() or not self.pickupWeaponClass then |
| end | ||
|
|
||
| tData:SetKeyBinding("+use") |
There was a problem hiding this comment.
now everbody can see the keybinding, could you please change it back so that only people that are able to pick it up see the binding?
Comment on lines
+208
to
+209
| local client = LocalPlayer() | ||
| if not IsValid(client) or not client:IsPlayer() or not client:IsActive() then |
There was a problem hiding this comment.
Suggested change
| local client = LocalPlayer() | |
| if not IsValid(client) or not client:IsPlayer() or not client:IsActive() then | |
| local client = LocalPlayer() | |
| if not IsValid(client) or not client:IsPlayer() or not client:IsActive() then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is implementing the new use workflow and gets rid of UseOverride.
Also C4 is now the first to properly use ClientUse to display a UI without routing it over the server.
As sidenote I fixed the Visualizer so that it can be picked up by the originator. This was only a problem if a non policing role should be able to buy it. Thats more in line with our general shop setup possibilities.