Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

playermodels: Unique Playermodels at round start #1487

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

Exonen2
Copy link

@Exonen2 Exonen2 commented Mar 20, 2024

At Round Start, if the option is activated, each player gets assigned a different playermodel from the pool.

Every Player gets a different model assigned at round start.
En Label added for unique model
De Label added for unique model
just fixed a short error on my side
fixed the spaces...
@TimGoll
Copy link
Member

TimGoll commented Mar 21, 2024

You know that this is already a thing in TTT2? :D

@Exonen2
Copy link
Author

Exonen2 commented Mar 21, 2024

You know that this is already a thing in TTT2? :D

Huh? Maybe I am blind lol...

Doesn't the current "model_per_Round" assign the same model to everyone at round start?

The Changes im proposing is that at round start everyone gets assigned a different model.

@TimGoll
Copy link
Member

TimGoll commented Mar 21, 2024

Oh sorry, then nevermind! I'll review it later today, thank you

Fixed the Inconsistent use of tabs and spaces for indentation and  Trailing whitespaces
@Histalek Histalek added the type/enhancement Enhancement or simple change to existing functionality label Mar 27, 2024
Copy link
Member

@TimGoll TimGoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review, it kind of got lost in my todo list.

I'd like to change this a bit. Your implementation now results in three modes:

  • random identical playermodel on map chanage
  • random identical playermodel on round change
  • random unique playermodel on round change

Imho it would be better to keep the two old modes as is (new model assignment on round or map change) and just modify your convar so it affects both modes. If your convar is enabled, a random unique player model is selected no matter the selection mode.

Does that make sense to you? I think this would be better and cleaner.

gamemodes/terrortown/gamemode/server/sv_main.lua Outdated Show resolved Hide resolved
@Exonen2
Copy link
Author

Exonen2 commented Apr 9, 2024

Sorry for the late review, it kind of got lost in my todo list.

I'd like to change this a bit. Your implementation now results in three modes:

  • random identical playermodel on map chanage
  • random identical playermodel on round change
  • random unique playermodel on round change

Imho it would be better to keep the two old modes as is (new model assignment on round or map change) and just modify your convar so it affects both modes. If your convar is enabled, a random unique player model is selected no matter the selection mode.

Does that make sense to you? I think this would be better and cleaner.

I was sadly quite busy the last 2 weeks but should be able to get to it soon.
But I think I get the gist of what you are saying.

@TimGoll
Copy link
Member

TimGoll commented Apr 9, 2024

No worries, I'm out of town as well. The proposed changes should probably be pretty easy for you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Enhancement or simple change to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants