Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add locational voice chat range cut-off setting #1503

Merged
merged 1 commit into from
Apr 7, 2024

Conversation

ruby0b
Copy link
Contributor

@ruby0b ruby0b commented Apr 6, 2024

@ruby0b
Copy link
Contributor Author

ruby0b commented Apr 6, 2024

Not sure if using 0 as a special value to disable the feature is idiomatic or if I should add a bool that enables/disables the cut-off being active.

@ruby0b
Copy link
Contributor Author

ruby0b commented Apr 6, 2024

As for the motivation for this feature: by default, you can basically still hear every player from anywhere on the map, they just get very quiet at some point which is probably not what most people want.

@ruby0b ruby0b mentioned this pull request Apr 6, 2024
4 tasks
@EntranceJew
Copy link
Contributor

Does this also account for the "local origin" issue where anyone standing near 0,0,0 will be able to hear conversations at a much higher volume due to the speaking player being in the PAS but not the PVS?

@ruby0b
Copy link
Contributor Author

ruby0b commented Apr 7, 2024

Sorry, I don't know anything about that issue (didn't even know that was a thing). Would that affect distance calculations?
If not then I guess this would fix that since you're guaranteed not to hear anyone outside the given range.

@EntranceJew
Copy link
Contributor

It is more like it is a problem that frequently crops up with distance-cutoff because the issue becomes more apparent when the voice range is relatively small but the map is dense, I'm surprised you haven't had it come up.

Copy link
Member

@saibotk saibotk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good and i think 0 is fine for disabled 🙌

Thank you so much for improving this.

@Histalek Histalek added the type/enhancement Enhancement or simple change to existing functionality label Apr 7, 2024
@Histalek Histalek added this to the v0.14.0b milestone Apr 7, 2024
Copy link
Member

@Histalek Histalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

using 0 to turn this is off is a good choice

@Histalek Histalek merged commit d4df150 into TTT-2:master Apr 7, 2024
5 checks passed
@ruby0b ruby0b deleted the locational_voice_range branch April 7, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Enhancement or simple change to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants