Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): allow rendering chat without auth #2185

Merged
merged 3 commits into from
May 21, 2024
Merged

fix(ui): allow rendering chat without auth #2185

merged 3 commits into from
May 21, 2024

Conversation

wwayne
Copy link
Collaborator

@wwayne wwayne commented May 20, 2024

Context

When I render /chat in the VSCode side bar, I don't wanna jump to the login page.

To improve

Without logging in, the chat component won't display the user's avatar (the image below). Looks we need to enhance the UI for this scenario. @liangfung

example

@wwayne wwayne requested a review from wsxiaoys May 20, 2024 09:48
@wsxiaoys wsxiaoys requested review from liangfung and removed request for wsxiaoys May 20, 2024 14:50
@wwayne
Copy link
Collaborator Author

wwayne commented May 21, 2024

@liangfung ready for review

@wwayne wwayne merged commit b90154e into main May 21, 2024
4 checks passed
@wwayne wwayne deleted the fix-auth branch May 21, 2024 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants