feat: shortcuts may provide a custom action for the intent #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #133 +/- ##
==========================================
+ Coverage 51.38% 51.49% +0.11%
==========================================
Files 50 50
Lines 3260 3270 +10
==========================================
+ Hits 1675 1684 +9
- Misses 1585 1586 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
@xtyxtyx Btw. a big thank you for adding tests and merging all the PRs so fast! :) |
|
Hello :-) Is something preventing this from being merged? Are some improvements / example to the PR required? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the possibility to set a custom action callback function for the intent corresponding to the shortcut. This can be useful for example, if the text to be pasted should be preprocessed before writing it to the terminal. For example special characters could cause problems could be removed.
The PR also adds handling of changes to the shortcuts property of the TerminalView. A new ShortcutManager is created in case the list of shortcuts. changes.
Furthermore it has been made easier to override default shortcuts, by adding a constructor to chose the proper modifier key for the current platform.