Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply naming conventions #265

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Apply naming conventions #265

wants to merge 3 commits into from

Conversation

gabrielvicenteYT
Copy link
Contributor

No description provided.

@gabrielvicenteYT
Copy link
Contributor Author

@lrmtheboss Can you do some things for me? This is going to be a lot of work, too much for 1 person.

@gabrielvicenteYT gabrielvicenteYT marked this pull request as ready for review November 6, 2023 10:00
@gabrielvicenteYT
Copy link
Contributor Author

It is mergable and usable, though it needs more stuff, it works.

lrmtheboss
lrmtheboss requested changes Nov 6, 2023
View reviewed changes
Copy link
Member

@lrmtheboss lrmtheboss left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the GitHub URL to https://raw.githubusercontent.com/TheUsefulLists/assets/main/images/platform_icons/github.png breaks it, it returns 404 not found if you open it in a new tab

Other wise everything else looks good

@lrmtheboss
Copy link
Member

@lrmtheboss Can you do some things for me? This is going to be a lot of work, too much for 1 person.

What would it be?

@gabrielvicenteYT
Copy link
Contributor Author

@lrmtheboss Can you do some things for me? This is going to be a lot of work, too much for 1 person.

What would it be?

making the URLs not have CAPS on

@lrmtheboss
Copy link
Member

making the URLs not have CAPS on

Why exactly?
I won't make any promises as it would be quite a large change

@gabrielvicenteYT
Copy link
Contributor Author

making the URLs not have CAPS on

Why exactly? I won't make any promises as it would be quite a large change

For readability, and the PR name itself: Apply naming conventions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrmtheboss lrmtheboss lrmtheboss requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gabrielvicenteYT @lrmtheboss