-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typeover null values in cell edit and row edit #9739
Open
shaurya-sharma064
wants to merge
4
commits into
release/database-1.1.1
Choose a base branch
from
feat/typeover-predefined-values
base: release/database-1.1.1
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Typeover null values in cell edit and row edit #9739
shaurya-sharma064
wants to merge
4
commits into
release/database-1.1.1
from
feat/typeover-predefined-values
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaurya-sharma064
changed the title
Feat/typeover predefined values
Typeover Null Values
May 16, 2024
Deployment: https://tooljet-pr-9739.onrender.com |
akshaysasidrn
changed the base branch from
release/database-1.1
to
release/database-1.1.1
May 16, 2024 06:29
akshaysasidrn
previously approved these changes
May 16, 2024
shaurya-sharma064
changed the title
Typeover Null Values
Typeover null values in cell edit and row edit
May 16, 2024
akshaysasidrn
dismissed
their stale review
May 22, 2024 06:01
The merge-base changed after approval.
Deployment: https://tooljet-pr-9739.onrender.com |
shaurya-sharma064
added
active-review-app
create-review-app
and removed
active-review-app
labels
May 28, 2024
Deployment: https://tooljet-pr-9739.onrender.com |
Mekhla-Asopa
added
active-review-app
tested
and removed
suspend-review-app
needs testing
labels
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #9709
Problem:
Couldn't update the null-valued cells directly without toggling to custom or pressing backspace.
Fix:
Have created a transparent wrapper around the input when the value is null.
Clicking on it will result into null value & the div disappearing and the pointer being focused back to the input field.