Update FarmPlotBlocks to automatically update from ItemLists when generating defaults. #7323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when generating defaults.
working. TODO: Fix setting the farmblocks list in the config.
LlmDl
force-pushed
the
update/plants_and_farm_blocks
branch
from
b332c8c
to
34c1935
Compare
specifically for farm blocks. This migration will only add to the list of blocks if the block is not already present. There is also a new runnable migration added to smartly update farm block lists in existing config with any missing blocks, while leaving any previously added blocks in the list.
LlmDl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR alters how we construct the list of default farm plot blocks, to use our ItemLists.
The ItemLists involving plants, crops and trees have been adjusted to be more comprehensive and detailed as well, adding some blocks which were missing.
This PR adds a new MigrationType specifically for farm blocks, which will be able to smartly add any new farm blocks if they are missing from the config.
Finally this PR adds a new Migration Runnable which will update existing config files' farm block lists with any missing blocks, using our new default block list.
New Nodes/Commands/ConfigOptions:
Relevant Towny Issue ticket:
By making this pull request, I represent that I have the right to waive copyright and related rights to my contribution, and agree that all copyright and related rights in my contributions are waived, and I acknowledge that the TownyAdvanced organization has the copyright to use and modify my contribution under the Towny License for perpetuity.