Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Endpoint detail page for remote instances #330

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Endpoint detail page for remote instances #330

wants to merge 11 commits into from

Conversation

praveen-livspace
Copy link

@praveen-livspace praveen-livspace commented Sep 14, 2022 •
edited by TwiN

Summary

Fixes: #329

Checklist

  • Tested and/or added tests to validate that the changes work as intended, if applicable.
  • Added the documentation in README.md, if applicable.

@praveen-livspace praveen-livspace marked this pull request as ready for review September 14, 2022 04:27
@praveen-livspace praveen-livspace mentioned this pull request Sep 14, 2022
Open
TwiN
TwiN requested changes Sep 26, 2022
View reviewed changes
Copy link
Owner

@TwiN TwiN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of comments.

All in all, there's a reason why I haven't resolved it yet; I'm just not sure what the right approach should be.

controller/handler/proxy.go Outdated Show resolved Hide resolved
controller/handler/endpoint_status.go Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TwiN TwiN Awaiting requested review from TwiN

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Detail page of remote endpoints throw 404
2 participants
@praveen-livspace @TwiN