refactor: replace useProject with useProjectOverview #7087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
kwasniew
commented
May 20, 2024
| @@ -50,4 +50,12 @@ export const useProjectOverviewNameOrId = (id: string): string => { | |||
| return useProjectOverview(id).project.name || id; | |||
| }; | |||
|
|
|||
| export const featuresCount = ( | |||
There was a problem hiding this comment.
backend doesn't return all features for the overview, but it already counts features by feature type so we can sum all types
sjaanus
reviewed
May 20, 2024
| onHover={() => | ||
| handleHover(project.id) | ||
| } | ||
| onHover={() => {}} |
There was a problem hiding this comment.
Why empty? make it optional or remove?
There was a problem hiding this comment.
underlying component makes it required and I'd like to remove it in a separate PR
sjaanus
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Important files
Discussion points