tools: update translation-related scripts #2998
Conversation
illwieckz
force-pushed
the
illwieckz/translation-tools
branch
2 times, most recently
from
38cf696
to
e203924
Compare
illwieckz
force-pushed
the
illwieckz/translation-tools
branch
from
e203924
to
2183ef2
Compare
illwieckz
force-pushed
the
illwieckz/translation-tools
branch
from
2183ef2
to
b63e1e1
Compare
| -k_ -kN_ -kP_:1,2 -k -f - | ||
| for name in 'game' 'commands' | ||
| do | ||
| if eval "\${${name}}" |
There was a problem hiding this comment.
What does this do? Why do we need eval?
There was a problem hiding this comment.
This line turns the game string contained into the variable name into the variable ${game} then eval executes it to get true or false.
|
|
||
| temp_pot_file="$(mktemp)" | ||
| . "${script_dir}/translation.conf" |
There was a problem hiding this comment.
Is it the same as source? If so please use that instead of cryptically golfing
There was a problem hiding this comment.
Yes, it's the same as source. Technically speaking, source is a bash-ism and . foo is more portable, but we do enforce bash anyways so its probably fine.
There was a problem hiding this comment.
Yes, this is the standard syntax for including a file. I can use source indeed since there is no plan to make it compatible with another language than bash.
| @@ -0,0 +1,51 @@ | |||
| #! /usr/bin/env bash | |||
|
|
|||
There was a problem hiding this comment.
/usr/bin/env is like which. /usr/bin/env is a "well known path" for env and will work on distros which do not have bash at /usr/bin like NixOS (ie, doing this is more portable than /usr/bin/bash
There was a problem hiding this comment.
lol I meant what is update_po.sh for
There was a problem hiding this comment.
Update the strings in .po files from the .pot file.
There was a problem hiding this comment.
Weblate does that automatically in our current workflow right? I'm not saying we shouldn't have the script but I would like to see a comment about that if is the case.
There was a problem hiding this comment.
I'm not sure Weblate does that automatically. Some months ago I noticed some strings were not in Weblate but in source, after having run that script and pushed, Weblate went in sync. Maybe that was a bug in Weblate, but I now always run ./generate_pot.sh then ./update_po.sh after merging translation changes from Weblate. In case it's not needed anymore it can't do harm anyway, I always run it to make sure everything is fine.
There was a problem hiding this comment.
It would be nice to have a comment about your experience with that.
|
|
||
| temp_pot_file="$(mktemp)" | ||
| . "${script_dir}/translation.conf" |
| then | ||
| temp_pot_file="$(mktemp)" | ||
|
|
||
| eval "generate_${name}_pot" |
There was a problem hiding this comment.
The eval seems to be superfluous. Like in external_deps/build.sh we do just "build_${pkg}"
| @@ -0,0 +1,51 @@ | |||
| #! /usr/bin/env bash | |||
|
|
|||
There was a problem hiding this comment.
It would be nice to have a comment about your experience with that.
commands.pot,we dont translate this for now and having to delete the file by hand on every rule of the script is annoying.
update_po.shscript,this automatically updates the existing
.pofiles using the.potfiles.It looks like I never found the time to push
update_po.shbefore.