Fixes for campaign mods #3813
Merged
Fixes for campaign mods #3813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If some were excluded from display / skipped
ManManson
approved these changes
May 19, 2024
Which could lead to issues unloading a campaign mod (if it provided its own videos)
past-due
changed the title
- seqPlayOrQueueFetch: Remove old "novideo.ogg" hack, silence logs for requests for "novideo.ogg" / "novideo.ogv" (or if falling back to on-demand provider) - seq_StartFullScreenVideo: Only start loop video playback mode if seqPlayOrQueueFetch succeeds
seq_hasVideos() should generally only be used for notifying the user now. seq_hasVideos() itself only does detection for built-in campaign videos (but it's possible that a campaign mod might bundle its own videos - so we just want to always attempt to load the video in most cases). seq_StartNextFullScreenVideo() now avoids triggering a blank screen / flicker if the video can't be found.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With these changes,
seq_hasVideos()should generally only be used for notifying the user now.(
seq_hasVideos()itself only does detection for built-in campaign videos, but it's possible that a campaign mod might bundle its own videos - so we just want to always attempt to load the video in most cases, now thatseq_StartNextFullScreenVideo()avoids triggering a blank screen / flicker if the video can't be found)