Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WASI-NN] neural_speed: add backend structure #3303

Merged
merged 18 commits into from
Jun 10, 2024
Merged

[WASI-NN] neural_speed: add backend structure #3303

merged 18 commits into from
Jun 10, 2024

Conversation

grorge123
Copy link
Contributor

No description provided.

@juntao Flows.network Integration
Copy link
Member

juntao commented Mar 25, 2024 •
edited

Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR.

@github-actions github-actions bot added c-Plugin An issue related to WasmEdge Plugin c-WASI-NN c-CMake labels Mar 25, 2024
@grorge123 grorge123 force-pushed the neural_speed branch 4 times, most recently from f916aeb to af7d519 Compare March 25, 2024 11:53
@grorge123 grorge123 requested a review from q82419 as a code owner March 25, 2024 11:53
@github-actions github-actions bot added the c-Test An issue/PR to enhance the test suite label Mar 25, 2024
@github-actions github-actions bot removed the c-Test An issue/PR to enhance the test suite label Mar 25, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 25, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.83%. Comparing base (6c6c4c4) to head (1e9122f).
Report is 2 commits behind head on master.

❗ Current head 1e9122f differs from pull request most recent head e089889

Please upload reports for the commit e089889 to get more accurate results.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3303      +/-   ##
==========================================
- Coverage   79.84%   79.83%   -0.01%     
==========================================
  Files         253      253              
  Lines       34948    34948              
  Branches     6142     6133       -9     
==========================================
- Hits        27905    27902       -3     
+ Misses       5622     5616       -6     
- Partials     1421     1430       +9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grorge123 grorge123 marked this pull request as draft March 25, 2024 12:55
@grorge123 grorge123 marked this pull request as ready for review March 29, 2024 06:22
@grorge123 grorge123 changed the title [WIP] [WASI-NN] neural_speed: add backend struct [WASI-NN] neural_speed: add backend structure Mar 29, 2024
@grorge123 grorge123 requested a review from hydai as a code owner April 8, 2024 06:35
@github-actions github-actions bot added the c-Test An issue/PR to enhance the test suite label Apr 8, 2024
@github-actions github-actions bot added c-CLI An issue related to WasmEdge CLI tools c-Installer c-CI labels Apr 25, 2024
@github-actions github-actions bot removed c-CLI An issue related to WasmEdge CLI tools c-Installer c-CI labels Apr 25, 2024
@grorge123 grorge123 force-pushed the neural_speed branch 3 times, most recently from a60159f to 984d13a Compare April 25, 2024 04:06
@grorge123 grorge123 requested a review from dannypsnl as a code owner June 7, 2024 10:18
@github-actions github-actions bot added the binding-java Java Bindings label Jun 7, 2024
@github-actions github-actions bot removed the binding-java Java Bindings label Jun 7, 2024
@grorge123 grorge123 force-pushed the neural_speed branch 2 times, most recently from 12156ce to 52521c1 Compare June 7, 2024 13:59
@grorge123
[WASI-NN] neural speed: add backend struct
0c8febc 
Signed-off-by: grorge <g97116@yahoo.com>
@grorge123
[WASI-NN] neural speed: add successful test
7a6b31c 
Signed-off-by: grorge <g97116@yahoo.com>
@grorge123
[WASI-NN] neural speed: implement neural network backend
0255114 
Signed-off-by: grorge <g97116@yahoo.com>
@grorge123
[WASI-NN] neural speed: fix neural backend and basic test
666c4e0 
Signed-off-by: grorge <g97116@yahoo.com>
@grorge123
[WASI-NN] neural speed: fix update pythonlib and share library
dadf7af 
Signed-off-by: grorge <g97116@yahoo.com>
@grorge123
[WASI-NN] neural speed: add setting model type
66c6158 
Signed-off-by: grorge <g97116@yahoo.com>
@grorge123
[WASI-NN] neural speed: fix python finalize deadlock
c045771 
Signed-off-by: grorge <g97116@yahoo.com>
@grorge123
[WASI-NN] neural speed: add successful test
0af0e79 
Signed-off-by: grorge <g97116@yahoo.com>
@grorge123
[WASI-NN] neural speed: update build neural speed cmake
987cb43 
Signed-off-by: grorge <g97116@yahoo.com>
@grorge123
[WASI-NN] neural speed: add neural speed backend ad unload function
88c327e 
Signed-off-by: grorge <g97116@yahoo.com>
@grorge123
[WASI-NN] neural speed: fix simdjson not fund
e7f83b1 
Signed-off-by: grorge <g97116@yahoo.com>
@grorge123
[WASI-NN] neural speed: fix remove finiSingle and set simdjson tags/v…
cd73e70 
…3.9.1

Signed-off-by: grorge <g97116@yahoo.com>
@grorge123
[WASI-NN] neural speed: add print run time
12e7df5 
Signed-off-by: grorge <g97116@yahoo.com>
@grorge123
[WASI-NN] neural speed: fix change time to chrono
4e23b48 
Signed-off-by: grorge <g97116@yahoo.com>
@grorge123
[WASI-NN] neural speed: fix windows dlopen
3863801 
Signed-off-by: grorge <g97116@yahoo.com>
@grorge123
[WASI-NN] neural speed: add more test
b07d658 
Signed-off-by: grorge <g97116@yahoo.com>
@grorge123
[WASI-NN] neural speed: change simdjson and small model
3f91059 
Signed-off-by: grorge <g97116@yahoo.com>
@grorge123
[WASI-NN] neural speed: Add build workflow
e089889 
Signed-off-by: grorge <g97116@yahoo.com>
@hydai
Copy link
Member

hydai commented Jun 7, 2024

cc @dm4 PTAL

dm4
dm4 approved these changes Jun 10, 2024
View reviewed changes
Copy link
Collaborator

@dm4 dm4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hydai hydai merged commit 258c5bb into WasmEdge:master Jun 10, 2024
81 of 85 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dm4 dm4 dm4 approved these changes

@hydai hydai hydai approved these changes

@ibmibmibm ibmibmibm Awaiting requested review from ibmibmibm ibmibmibm is a code owner

@q82419 q82419 Awaiting requested review from q82419 q82419 is a code owner

@dannypsnl dannypsnl Awaiting requested review from dannypsnl

Assignees
No one assigned
Labels
c-CI c-CMake c-Plugin An issue related to WasmEdge Plugin c-Test An issue/PR to enhance the test suite c-WASI-NN v-0.14.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@grorge123 @juntao @hydai @dm4