Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mouse scroll #1962

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

PeterOGB
Copy link

No description provided.

@PeterOGB
Copy link
Author

Here are the changes to add mouse button scrolling.

Copy link
Member

@ammen99 ammen99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder:

  • How would the user figure out which button to use, when they have integer numbers? Where does the number come from? Would it be possible to for example use string button names left/right/etc or maybe BTN_LEFT/BTN_RIGHT/etc (the latter are evdev button names, I am not sure if they are applicable here).

  • We already have an option which is unfortunately called simply scroll_method and is applied for touchpads, whereas this is exclusively for mice .. I wonder whether it will make sense to figure out support for per-device settings before we add even more duplicated options.
    Alternatively (and will probably be the easier solution atm): does the scroll method setting actually influence 'real' mice (as opposed to touchpads and whatever hardware you have)? If it does not, then maybe we can just have one single global option for scroll method, which is applied to all devices.

TLDR: I don't like that we have duplicate options for scroll_method.

@PeterOGB
Copy link
Author

PeterOGB commented Oct 19, 2023 via email

@PeterOGB
Copy link
Author

I now have a Logitech trackball (with four buttons) , an HP mouse (with three buttons and scroll wheel) and a Wacom Intuos BT M Pad and Pen (with four buttons on the tablet and two buttons on the pen) connected so I can try and figure out a way to configure for them all: -) The libinput tool is providing useful information on them all.

@ammen99
Copy link
Member

ammen99 commented Oct 19, 2023

Tablet input is unrelated to these libinput settings - but it would be great to figure out if this option interferes with regular mice. If it doesn't, we can just use one option which is set for all devices.

@PeterOGB
Copy link
Author

But looking at the output from liboutput list-devices for as many different device types will help ensure there are no unexpected consequences. For example I do now know that tablets return LIBINPUT_CONFIG_SCROLL_NO_SCROLL !

@Beryesa
Copy link

Beryesa commented Dec 18, 2023

Not particularly about this PR but just wanted to mention that, button scrolling is an incredibly useful feature for graphics tablets / styluses as we lack pen interactions a lot in comparison to touch (where some clients nicely scroll on swipe etc) in our ecosystem :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants