-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose document.fragmentDirective (feature detection for text fragments) #28784
Expose document.fragmentDirective (feature detection for text fragments) #28784
Conversation
EWS run on previous version of this PR (hash 746608b) |
746608b
to
3bfd05f
Compare
EWS run on previous version of this PR (hash 3bfd05f) |
Can we add a runtime flag for this? |
3bfd05f
to
13a15e7
Compare
EWS run on previous version of this PR (hash 13a15e7)
|
13a15e7
to
5940546
Compare
EWS run on previous version of this PR (hash 5940546)
|
5940546
to
5c85717
Compare
EWS run on previous version of this PR (hash 5c85717) |
5c85717
to
72737b0
Compare
EWS run on previous version of this PR (hash 72737b0) |
72737b0
to
85f9265
Compare
EWS run on previous version of this PR (hash 85f9265) |
85f9265
to
817a5bf
Compare
EWS run on previous version of this PR (hash 817a5bf) |
OK, added |
817a5bf
to
8e807a0
Compare
EWS run on previous version of this PR (hash 8e807a0) |
8e807a0
to
a5181e6
Compare
EWS run on current version of this PR (hash a5181e6) |
@rniwa EWS is all green here now. OK for me to add the merge-queue label, or did you want for other reviewers to also review this? |
You can land it now. |
https://bugs.webkit.org/show_bug.cgi?id=273466 Reviewed by Ryosuke Niwa. This change makes WebKit expose the document.fragmentDirective property from https://wicg.github.io/scroll-to-text-fragment/#feature-detectability — to enable developers to programmatically detect that WebKit supports the scroll-to-text-fragment feature. (Controlled by the new preference ScrollToTextFragmentFeatureDetectionEnabled, also introduced in this change.) Otherwise, without this change, developers can’t programatically detect that WebKit supports the scroll-to-text-fragment feature. * LayoutTests/imported/w3c/web-platform-tests/scroll-to-text-fragment/scroll-to-text-fragment-api-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/scroll-to-text-fragment/scroll-to-text-fragment-api.html: Added. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WebCore/CMakeLists.txt: * Source/WebCore/DerivedSources-input.xcfilelist: * Source/WebCore/DerivedSources-output.xcfilelist: * Source/WebCore/DerivedSources.make: * Source/WebCore/Headers.cmake: * Source/WebCore/Sources.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/bindings/js/WebCoreBuiltinNames.h: * Source/WebCore/dom/Document.cpp: * Source/WebCore/dom/Document.h: (WebCore::Document::fragmentDirectiveForBindings): * Source/WebCore/dom/Document.idl: * Source/WebCore/page/FragmentDirective.h: Added. (WebCore::FragmentDirective::create): * Source/WebCore/page/FragmentDirective.idl: Added. Canonical link: https://commits.webkit.org/279258@main
a5181e6
to
04bd634
Compare
Committed 279258@main (04bd634): https://commits.webkit.org/279258@main Reviewed commits have been landed. Closing PR #28784 and removing active labels. |
04bd634
a5181e6