[Navigation] Support "initial about:blank document" logic #28792

rwlbuis · 2024-05-20T16:19:02Z

`7d612aa`

[Navigation] Support "initial about:blank document" logic
https://bugs.webkit.org/show_bug.cgi?id=274393

Reviewed by NOBODY (OOPS!).

Keep track of the "initial about:blank document" flag and check it in
the "has entries and events disabled" algorithm.

[1] https://html.spec.whatwg.org/multipage/nav-history-apis.html#has-entries-and-events-disabled (Step 3)

* LayoutTests/imported/w3c/web-platform-tests/navigation-api/currententrychange-event/navigate-from-initial-about-blank-same-doc-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/navigation-api/currententrychange-event/navigate-from-initial-about-blank-same-doc-popup-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/navigation-api/updateCurrentEntry-method/exception-order-initial-about-blank-unserializablestate-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/navigation-api/updateCurrentEntry-method/initial-about-blank-expected.txt:
* Source/WebCore/dom/Document.h:
(WebCore::Document::isInitialAboutBlank const):
(WebCore::Document::setIsInitialAboutBlank):
* Source/WebCore/loader/DocumentWriter.cpp:
(WebCore::DocumentWriter::end):
* Source/WebCore/page/Navigation.cpp:
(WebCore::Navigation::hasEntriesAndEventsDisabled const):

7d612aa

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 wincairo-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
	❌ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-05-20T16:20:12Z

EWS run on previous version of this PR (hash c81d8c8)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 wincairo-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	❌ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
🛠 🧪 jsc	✅ 🧪 api-ios	❌ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress	❌ 🧪 api-gtk
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-05-21T16:03:43Z

EWS run on previous version of this PR (hash b9d79a4)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2	✅ 🧪 wincairo-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	❌ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
🛠 🧪 jsc	✅ 🧪 api-ios	❌ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 tv	❌ 🧪 mac-AS-debug-wk2	❌ 🧪 gtk-wk2
	✅ 🛠 tv-sim	❌ 🧪 mac-wk2-stress	❌ 🧪 api-gtk
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-05-22T15:15:51Z

EWS run on previous version of this PR (hash 4450c08)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2	✅ 🧪 wincairo-tests
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	⏳ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
	⏳ 🧪 api-ios	❌ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 tv	~~🧪 mac-AS-debug-wk2~~	❌ 🧪 gtk-wk2
	✅ 🛠 tv-sim	❌ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-05-22T20:32:45Z

EWS run on previous version of this PR (hash 0f10b9d)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~	✅ 🧪 wincairo-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	❌ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
	✅ 🧪 api-ios	❌ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 tv	❌ 🧪 mac-AS-debug-wk2	~~🧪 gtk-wk2~~
	✅ 🛠 tv-sim	❌ 🧪 mac-wk2-stress	~~🧪 api-gtk~~
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-05-23T03:52:43Z

EWS run on previous version of this PR (hash 7266be7)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2	✅ 🧪 wincairo-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	❌ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
	✅ 🧪 api-ios	❌ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 tv	❌ 🧪 mac-AS-debug-wk2	❌ 🧪 gtk-wk2
	✅ 🛠 tv-sim	❌ 🧪 mac-wk2-stress	❌ 🧪 api-gtk
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-05-23T19:23:17Z

EWS run on previous version of this PR (hash 1563fb2)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2	✅ 🧪 wincairo-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	❌ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
	✅ 🧪 api-ios	❌ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 tv	❌ 🧪 mac-AS-debug-wk2	❌ 🧪 gtk-wk2
	✅ 🛠 tv-sim	❌ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-05-24T06:23:14Z

EWS run on previous version of this PR (hash affa258)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2	✅ 🧪 wincairo-tests
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	❌ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
	✅ 🧪 api-ios	❌ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 tv	❌ 🧪 mac-AS-debug-wk2	❌ 🧪 gtk-wk2
	✅ 🛠 tv-sim	❌ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-05-27T18:29:28Z

EWS run on previous version of this PR (hash 863a2a1)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2	✅ 🧪 wincairo-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	❌ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
	✅ 🧪 api-ios	❌ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 tv	❌ 🧪 mac-AS-debug-wk2	❌ 🧪 gtk-wk2
	✅ 🛠 tv-sim	❌ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-05-28T09:15:47Z

EWS run on previous version of this PR (hash cd2d8ca)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	❌ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2	✅ 🧪 wincairo-tests
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🧪 api-mac	❌ 🧪 api-wpe
	⏳ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
	⏳ 🧪 api-ios	❌ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 tv	❌ 🧪 mac-AS-debug-wk2	❌ 🧪 gtk-wk2
	✅ 🛠 tv-sim	❌ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🛠 watch
	✅ 🛠 watch-sim

https://bugs.webkit.org/show_bug.cgi?id=274393 Reviewed by NOBODY (OOPS!). Keep track of the "initial about:blank document" flag and check it in the "has entries and events disabled" algorithm. [1] https://html.spec.whatwg.org/multipage/nav-history-apis.html#has-entries-and-events-disabled (Step 3) * LayoutTests/imported/w3c/web-platform-tests/navigation-api/currententrychange-event/navigate-from-initial-about-blank-same-doc-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/currententrychange-event/navigate-from-initial-about-blank-same-doc-popup-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/updateCurrentEntry-method/exception-order-initial-about-blank-unserializablestate-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/updateCurrentEntry-method/initial-about-blank-expected.txt: * Source/WebCore/dom/Document.h: (WebCore::Document::isInitialAboutBlank const): (WebCore::Document::setIsInitialAboutBlank): * Source/WebCore/loader/DocumentWriter.cpp: (WebCore::DocumentWriter::end): * Source/WebCore/page/Navigation.cpp: (WebCore::Navigation::hasEntriesAndEventsDisabled const):

webkit-early-warning-system · 2024-05-28T12:50:23Z

EWS run on current version of this PR (hash 7d612aa)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 wincairo-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
	❌ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🛠 watch
	✅ 🛠 watch-sim

achristensen07 · 2024-05-29T22:13:04Z

Source/WebCore/dom/Document.h

@@ -2597,6 +2600,8 @@ class Document
    bool m_scheduledDeferredAXObjectCacheUpdate { false };
    bool m_wasRemovedLastRefCalled { false };

+    bool m_isInitialAboutBlank { false };


The FrameLoader already has this state:
bool isShowingInitialAboutBlank = m_localFrame->loader().stateMachine().isDisplayingInitialEmptyDocument()

rwlbuis requested review from cdumez and rniwa as code owners May 20, 2024 16:19

rwlbuis self-assigned this May 20, 2024

rwlbuis added the WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore). label May 20, 2024

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 20, 2024

rwlbuis removed the merging-blocked Applied to prevent a change from being merged label May 21, 2024

rwlbuis force-pushed the eng/Navigation-Support-initial-aboutblank-document-logic branch from c81d8c8 to b9d79a4 Compare May 21, 2024 16:03

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 21, 2024

rwlbuis removed the merging-blocked Applied to prevent a change from being merged label May 22, 2024

rwlbuis force-pushed the eng/Navigation-Support-initial-aboutblank-document-logic branch from b9d79a4 to 4450c08 Compare May 22, 2024 15:15

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 22, 2024

rwlbuis removed the merging-blocked Applied to prevent a change from being merged label May 22, 2024

rwlbuis force-pushed the eng/Navigation-Support-initial-aboutblank-document-logic branch from 4450c08 to 0f10b9d Compare May 22, 2024 20:32

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 23, 2024

rwlbuis removed request for rniwa and cdumez May 23, 2024 03:44

rwlbuis removed the merging-blocked Applied to prevent a change from being merged label May 23, 2024

rwlbuis force-pushed the eng/Navigation-Support-initial-aboutblank-document-logic branch from 0f10b9d to 7266be7 Compare May 23, 2024 03:52

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 23, 2024

rwlbuis removed the merging-blocked Applied to prevent a change from being merged label May 23, 2024

rwlbuis force-pushed the eng/Navigation-Support-initial-aboutblank-document-logic branch from 7266be7 to 1563fb2 Compare May 23, 2024 19:22

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 24, 2024

rwlbuis removed the merging-blocked Applied to prevent a change from being merged label May 24, 2024

rwlbuis force-pushed the eng/Navigation-Support-initial-aboutblank-document-logic branch from 1563fb2 to affa258 Compare May 24, 2024 06:23

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 24, 2024

rwlbuis removed the merging-blocked Applied to prevent a change from being merged label May 27, 2024

rwlbuis force-pushed the eng/Navigation-Support-initial-aboutblank-document-logic branch from affa258 to 863a2a1 Compare May 27, 2024 18:29

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 27, 2024

rwlbuis removed the merging-blocked Applied to prevent a change from being merged label May 28, 2024

rwlbuis force-pushed the eng/Navigation-Support-initial-aboutblank-document-logic branch from 863a2a1 to cd2d8ca Compare May 28, 2024 09:15

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 28, 2024

rwlbuis removed the merging-blocked Applied to prevent a change from being merged label May 28, 2024

rwlbuis force-pushed the eng/Navigation-Support-initial-aboutblank-document-logic branch from cd2d8ca to 7d612aa Compare May 28, 2024 12:50

rwlbuis requested a review from achristensen07 May 28, 2024 15:36

achristensen07 requested changes May 29, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Navigation] Support "initial about:blank document" logic #28792

[Navigation] Support "initial about:blank document" logic #28792

rwlbuis commented May 20, 2024 •

edited by webkit-early-warning-system

webkit-early-warning-system commented May 20, 2024 •

edited

webkit-early-warning-system commented May 21, 2024 •

edited

webkit-early-warning-system commented May 22, 2024 •

edited

webkit-early-warning-system commented May 22, 2024 •

edited

webkit-early-warning-system commented May 23, 2024 •

edited

webkit-early-warning-system commented May 23, 2024 •

edited

webkit-early-warning-system commented May 24, 2024 •

edited

webkit-early-warning-system commented May 27, 2024 •

edited

webkit-early-warning-system commented May 28, 2024 •

edited

webkit-early-warning-system commented May 28, 2024 •

edited

achristensen07 May 29, 2024

[Navigation] Support "initial about:blank document" logic #28792

Are you sure you want to change the base?

[Navigation] Support "initial about:blank document" logic #28792

Conversation

rwlbuis commented May 20, 2024 • edited by webkit-early-warning-system

7d612aa

webkit-early-warning-system commented May 20, 2024 • edited

webkit-early-warning-system commented May 21, 2024 • edited

webkit-early-warning-system commented May 22, 2024 • edited

webkit-early-warning-system commented May 22, 2024 • edited

webkit-early-warning-system commented May 23, 2024 • edited

webkit-early-warning-system commented May 23, 2024 • edited

webkit-early-warning-system commented May 24, 2024 • edited

webkit-early-warning-system commented May 27, 2024 • edited

webkit-early-warning-system commented May 28, 2024 • edited

webkit-early-warning-system commented May 28, 2024 • edited

achristensen07 May 29, 2024

Choose a reason for hiding this comment

rwlbuis commented May 20, 2024 •

edited by webkit-early-warning-system

`7d612aa`

webkit-early-warning-system commented May 20, 2024 •

edited

webkit-early-warning-system commented May 21, 2024 •

edited

webkit-early-warning-system commented May 22, 2024 •

edited

webkit-early-warning-system commented May 22, 2024 •

edited

webkit-early-warning-system commented May 23, 2024 •

edited

webkit-early-warning-system commented May 23, 2024 •

edited

webkit-early-warning-system commented May 24, 2024 •

edited

webkit-early-warning-system commented May 27, 2024 •

edited

webkit-early-warning-system commented May 28, 2024 •

edited

webkit-early-warning-system commented May 28, 2024 •

edited