Add a unit-test to test the overlay connection with mtSTART_PROTOCOL message #4861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on start. Add InboundHandoff class to complete HTTP handshake and instantiate inbound PeerImp. Add GracefulClose message to close a peer connection on an application level error.
the last message is graceful close or if aborted and close flag is set. Don't close right after sending graceful close.
[FOLD] Add required include for non-unity build. Make InboundHandoff non-copiable.
gregtatcam
force-pushed
the
start-protocol
branch
from
5c4bd4e
to
d6a0031
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This is an extension of #3839 PR. It adds a pseudo-configurable parameters to
Configclass. These parameters are not configurable viaripple.cfg. The parameters facilitate setting up the overlay with virtual nodes in unit-tests. A unit-test is added to test the overlay connectivity with the added start protocol message for two peers where: 1) both peers use the protocol version 2.3; 2) one of the peers uses the protocol version 2.3 and another peer uses the protocol version 2.2.Context of Change
Two parameters are added to
Configclass.ALLOW_OVERLAYparameter overwritesstandalonemode behavior of disabling the overlay. It allows creation of the overlay between the configured fixed ip's of the virtual nodes within the unit-test.PROTOCOL_VERSIONSparameter simulates a peer with different protocol versions. This enables backward compatibility testing of the start protocol message. Peer'smetricsis extended with two dictionaries:messge_type_sentandmessage_type_recv, which contain frequencies of message type for sent and received messages respectively. The added metrics enables testing of the protocol messages propagation.Type of Change
.gitignore, formatting, dropping support for older tooling)Test Plan
A new unit-test
ProtocolStartis added.