Return CheckID from CheckCreate transaction #4898
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This is an attempt to address the concerns raised in XRPLF/xrpl-py#356
Many thanks to @ximinez for brain-storming with me and giving me these ideas.
It is useful to return the
CheckID
after a successfulCheckCreate
transaction. At the moment, developers need to make multiple network calls (or) perform the necessary computation to calculate theCheckID
. That is cumbersome.I've built this branch off of #4864. The referenced work has necessary refactor of the
submit
command.Context of Change
CheckCreate
transaction returns theCheckID
upon successful completion.CheckID
is placed at the top level of the response, along with other fields likestatus
,engine_result
, etc.I have also modified the unit tests to accomodate return values from the
submit
RPC command. Up until now, we were not able to access or validate the responses of the submit command within theEnv
framework.Type of Change
.gitignore
, formatting, dropping support for older tooling)API Impact
libxrpl
change (any change that may affectlibxrpl
or dependents oflibxrpl
)Performance Impact: This PR does not affect Performance of the rippled codebase
Test Plan
I've updated two of the existing unit tests to validate the output of
CheckCreate
transaction.@ximinez @mDuo13 Please let me know if this looks okay