-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XLS-60d: DefaultAutoBridge #4923
Open
tequdev
wants to merge
14
commits into
XRPLF:develop
Choose a base branch
from
tequdev:featureDefaultAutoBridge
base: develop
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+236
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4923 +/- ##
===========================================
+ Coverage 76.97% 76.98% +0.01%
===========================================
Files 1129 1129
Lines 131914 132045 +131
Branches 39629 39726 +97
===========================================
+ Hits 101539 101659 +120
- Misses 24459 24519 +60
+ Partials 5916 5867 -49 ☔ View full report in Codecov by Sentry. |
tequdev
force-pushed
the
featureDefaultAutoBridge
branch
from
April 16, 2024 12:24
646cf62
to
2ef6409
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Changes the internal default path to include the path of the XRP bridge if sfPaths is unspecified in the Payment transaction.
Context of Change
XRPLF/XRPL-Standards#175
Type of Change
Before / After
If relevant, use this section for an English description of the change at a technical level.
If no path is specified, the impact of the transaction on the node is increased, but if a path is set to mediate XRP, the impact on the node is unaffected.