remove the type filter from "ledger" RPC command

[ckeshava]

High Level Overview of Change

This issue was reported on the Javascript client library: XRPLF/xrpl.js#2611

The type filter (Note: as of the latest version of rippled, type parameter is deprecated) does not work as expected. This PR removes the type filter from the ledger command.

Context of the bug

I have not investigated the full extent of this issue. I have reproduced the issue on this branch: https://github.com/XRPLF/rippled/compare/develop...ckeshava:rippled:failingTestCasesTypeFilter?expand=1

Note: The above branch has annotations about which portions of the codebase are responsible for the wrong behavior.

Both ledger_data and ledger commands must behave identically with respect to the type filter, but that is not the case. While the above branch demonstrates failing tests, I'd like to highlight two tests that work correctly:

rippled/src/test/rpc/LedgerRPC_test.cpp

Line 2241 in 8a2f6be

testLedgerAccountsOption()

This behavior occurs because of a specific combination of expand, accounts and full parameters in the ledger command.

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Refactor (non-breaking change that only restructures code)
• Performance (increase or change in throughput and/or latency)
• Tests (you added tests for code that already exists, or your new feature included in this PR)
• Documentation update
• Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
• Release
• Removal of feature, removal of associated unit tests too

API Impact

• Public API: New feature (new methods and/or new fields)

• Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  type parameter can no longer be used with the ledger RPC command

• libxrpl change (any change that may affect libxrpl or dependents of libxrpl)

• Peer protocol change (must be backward compatible or bump the peer protocol version)

No impact on performance of rippled

[ckeshava]

@ximinez @HowardHinnant please review this PR at your convenience