Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat code according to clang-format-15 #4938

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

thejohnfreeman
Copy link
Collaborator

clang-format-10 is no longer available on the latest version of Ubuntu (23.10). clang-format-15 is the latest version available on the latest Ubuntu GitHub runner image (22.04). It does a much better job formatting requires clauses, for one.

We weren't formatting the few headers ending in .hpp either, which this PR corrects.

@codecov-commenter
Copy link

codecov-commenter commented Mar 1, 2024

Codecov Report

Attention: Patch coverage is 55.02959% with 76 lines in your changes are missing coverage. Please review.

Project coverage is 61.61%. Comparing base (8a2f6be) to head (0dadf72).
Report is 1 commits behind head on develop.

Files Patch % Lines
src/ripple/beast/unit_test/match.hpp 14.28% 22 Missing and 2 partials ⚠️
src/ripple/beast/unit_test/suite.hpp 51.16% 13 Missing and 8 partials ⚠️
src/ripple/beast/unit_test/thread.hpp 0.00% 8 Missing ⚠️
src/ripple/beast/test/yield_to.hpp 71.42% 1 Missing and 3 partials ⚠️
src/ripple/beast/unit_test/suite_info.hpp 20.00% 2 Missing and 2 partials ⚠️
src/ripple/beast/unit_test/runner.hpp 40.00% 1 Missing and 2 partials ⚠️
src/ripple/beast/insight/impl/NullCollector.cpp 50.00% 2 Missing ⚠️
src/ripple/beast/unit_test/suite_list.hpp 60.00% 0 Missing and 2 partials ⚠️
src/ripple/app/misc/impl/ValidatorList.cpp 0.00% 1 Missing ⚠️
src/ripple/basics/Expected.h 92.85% 0 Missing and 1 partial ⚠️
... and 6 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4938      +/-   ##
===========================================
- Coverage    61.62%   61.61%   -0.01%     
===========================================
  Files          804      804              
  Lines        70642    70620      -22     
  Branches     36534    36531       -3     
===========================================
- Hits         43530    43513      -17     
+ Misses       19803    19801       -2     
+ Partials      7309     7306       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mvadari
Copy link
Collaborator

mvadari commented Mar 1, 2024

Can the .pre-commit-config.yaml file also be updated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants