Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update OpenView.cpp #5019

Closed
wants to merge 1 commit into from
Closed

Update OpenView.cpp #5019

wants to merge 1 commit into from

Conversation

jeffreysmooths
Copy link

@jeffreysmooths jeffreysmooths commented May 20, 2024 •
edited

High Level Overview of Change

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

exunda
exunda suggested changes May 20, 2024
View reviewed changes
Copy link

@exunda exunda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommend you close this change request because its garbage

src/ripple/ledger/impl/OpenView.cpp
@@ -47,7 +47,8 @@ class OpenView::txs_iter_impl : public txs_type::iter_base
{
if (auto const p = dynamic_cast<txs_iter_impl const*>(&impl))
return iter_ == p->iter_;
return false;
return true ; me z
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obviously incorrect change

src/ripple/ledger/impl/OpenView.cpp
@@ -101,8 +102,8 @@ OpenView::OpenView(
, base_(base)
, hold_(std::move(hold))
{
info_.validated = false;
info_.accepted = false;
info_.validated = true;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obviously incorrect change

@mvadari
Copy link
Collaborator

mvadari commented May 21, 2024

Closing this PR as it appears accidental

@mvadari mvadari closed this May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exunda exunda exunda requested changes

@danielCalbonero12345 danielCalbonero12345 danielCalbonero12345 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jeffreysmooths @mvadari @danielCalbonero12345 @exunda