upgrade react dependencies and upgrade test dependencies. #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulinfrancis
commented
May 16, 2019
paulinfrancis
commented
- componentWillReceiveProps -> getDerivedStateFromProps, prevents warning in React.StrictMode
- Upgrade react dependencies to ^16.4.0.
- Fix tests and upgrade test packages
- Upgrade babel packages to latest 6.x. I am happy to submit a new PR later on with latest Webpack and babel.
added 4 commits
May 16, 2019 13:48
…e Toggle not cause warnings in React.StrictMode.
paulinfrancis
changed the title
paulinfrancis
changed the title
paulinfrancis
changed the title
|
Is there an ETA on when this PR will be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.