Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map - Use SlotItemChanged event #9961

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

johnb432
Copy link
Contributor

When merged this pull request will:

  • Title.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@johnb432 johnb432 added kind/enhancement Release Notes: **IMPROVED:** 2.18 labels Apr 20, 2024
@johnb432 johnb432 changed the title Map - Use slotItemChanged event Map - Use SlotItemChanged event May 28, 2024
@johnb432 johnb432 added kind/optimization Release Notes: **IMPROVED:** and removed kind/enhancement Release Notes: **IMPROVED:** labels May 28, 2024

private _ehID = _oldPlayer getVariable QGVAR(ehID);

if (!isNil "_ehID") then {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should just make this whole setup into a macro at this point

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's neat. Pull that out of that PR?

@LinkIsGrim
Copy link
Contributor

LinkIsGrim commented Jun 4, 2024

Does this actually need 2.18? SlotItemChanged has been a thing since 2.14

@johnb432
Copy link
Contributor Author

johnb432 commented Jun 4, 2024

Does this actually need 2.18? SlotItemChanged has been a thing since 2.14

It's broken in 2.16 stable.

Copy link
Contributor

@LinkIsGrim LinkIsGrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2.18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.18 kind/optimization Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants