Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grenades - Fix how incendiary grenades do damage to vehicles #9983

Merged
merged 8 commits into from
Jun 11, 2024
Merged

Grenades - Fix how incendiary grenades do damage to vehicles #9983

merged 8 commits into from
Jun 11, 2024

Conversation

johnb432
Copy link
Contributor

@johnb432 johnb432 commented Apr 28, 2024 •
edited

When merged this pull request will:

  • Allow incendiary grenades to damage multiple vehicles.
  • Disables incendiaries damaging invulnerable vehicles.
  • Already burning incendiaries did not destroy a vehicle's wheels, it only checked when the incendiary detonated. I'll have to think of a solution, but not for this PR. I included this fix in the PR after all.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@johnb432
Allow incendiary grenades to damage multiple vehicles
9e6b76b 
Disable incendiaries damaging invulnerable vehicles
@johnb432 johnb432 added the kind/bug-fix Release Notes: **FIXED:** label Apr 28, 2024
@johnb432 johnb432 mentioned this pull request Apr 28, 2024
Open
@johnb432 johnb432 added this to the 3.18.0 milestone May 9, 2024
LinkIsGrim
LinkIsGrim approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@LinkIsGrim LinkIsGrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnb432 johnb432 merged commit 9760095 into master Jun 11, 2024
5 checks passed
@johnb432 johnb432 deleted the incendiary-damage-multiple-vehicles branch June 11, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinkIsGrim LinkIsGrim LinkIsGrim approved these changes

Assignees
No one assigned
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Milestone
3.18.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@johnb432 @LinkIsGrim