Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cargo - Add checks for adding cargo via config #9999

Merged
merged 3 commits into from
May 22, 2024
Merged

Cargo - Add checks for adding cargo via config #9999

merged 3 commits into from
May 22, 2024

Conversation

johnb432
Copy link
Contributor

@johnb432 johnb432 commented May 8, 2024 •
edited

When merged this pull request will:

  • Title.
  • Prints warnings if config defined cargo doesn't fit in a vehicle.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@johnb432 johnb432 added the kind/enhancement Release Notes: **IMPROVED:** label May 8, 2024
@johnb432 johnb432 added this to the 3.18.0 milestone May 9, 2024
PabstMirror
PabstMirror approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@PabstMirror PabstMirror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@PabstMirror PabstMirror merged commit 052f1c9 into master May 22, 2024
5 checks passed
@PabstMirror PabstMirror deleted the cargo-ignore-interaction-condition branch May 22, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PabstMirror PabstMirror PabstMirror approved these changes

Assignees
No one assigned
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Milestone
3.18.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@johnb432 @PabstMirror