Markdown table fixes

[naktinis]

Contains the following fixes:

• do not add new lines in markdown cells
• markdown tables can only have one header
• add a space after text before a paragraph in a cell
• match maximum cell count on each row
• cells always need to append vertical bars

Partly fixes #599.

[adbar]

@naktinis Thanks for the PR, the code looks good but tests fails in test_table_processing() (part of unit_tests.py).

Could you please have a look, change the code (or the test if it doesn't work as intended), and add tests there for your PR if necessary?

[naktinis]

@adbar I believe I have now fixed the tests and added three more relating to these changes.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.94%. Comparing base (1ce0e76) to head (91f7a78).
Report is 4 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #601   +/-   ##
=======================================
  Coverage   97.94%   97.94%           
=======================================
  Files          21       21           
  Lines        3498     3508   +10     
=======================================
+ Hits         3426     3436   +10     
  Misses         72       72           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[adbar]

@naktinis Thanks, it's much better now!

I have a few questions:

• You're introducing a span attribute because otherwise it would be difficult to keep track of the total number of columns, right?
• Why does it yield <rowspan="2"> (without space) and <row span="7"> in the tests? I would suggest to remove the attribute from the output once it has been used.

[naktinis]

@adbar

You're introducing a span attribute because otherwise it would be difficult to keep track of the total number of columns, right?

Yes, so that each row is aware of any other rows having more columns than it does itself.

Why does it yield <rowspan="2"> (without space) and in the tests? I would suggest to remove the attribute from the output once it has been used.

Because the previous line (that was already there before my changes) removes spaces:

result = processed.replace('\n', '').replace(' ', '')

[adbar]

Then I'd be in favor of removing the attribute from the output:

• somewhere after for subelement in table_elem.iterdescendants():
• del newrow.attrib["span"] (if it's present)

Could you please implement the change (or a similar one) and update the tests?

[naktinis]

@adbar row attribute cleanup should now be done (also updated the tests).

[adbar]

Thanks!