chore: updated tokens processing and now we're creating legacy-overrides for S1/Express
#4442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into jnjosh/theming-systems
…ctrum-web-components into jnjosh/theming-systems
Lighthouse scores
What is this?Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on Transfer Size
Request Count
|
Tachometer resultsChromeaction-bar permalinkbasic-test
action-menu permalinktest-basic
test-directive permalink
test-lazy permalink
test-open-close-directive permalink
test-open-close permalink
card permalinktest-basic
combobox permalinkbasic-test
light-dom-test permalink
illustrated-message permalinktest-basic
menu permalinktest-basic
overlay permalinkbasic-test
directive-test permalink
element-test permalink
lazy-test permalink
picker permalinkbasic-test
popover permalinktest-basic
slider permalinktest-basic
split-button permalinkbasic-test
tooltip permalinktest-basic
test-directive permalink
test-element permalink
test-lazy permalink
truncated permalinkbasic-test
Firefoxaction-bar permalinkbasic-test
action-menu permalinktest-basic
test-directive permalink
test-lazy permalink
test-open-close-directive permalink
test-open-close permalink
card permalinktest-basic
combobox permalinkbasic-test
light-dom-test permalink
illustrated-message permalinktest-basic
menu permalinktest-basic
overlay permalinkbasic-test
directive-test permalink
element-test permalink
lazy-test permalink
picker permalinkbasic-test
popover permalinktest-basic
slider permalinktest-basic
split-button permalinkbasic-test
tooltip permalinktest-basic
test-directive permalink
test-element permalink
test-lazy permalink
truncated permalinkbasic-test
|
TarunAdobe
changed the title
spectrum-css's S2 bridgelegacy-overrides for S1/Express
9 tasks
| // check if spectrumPath exists | ||
| if (fs.existsSync(spectrumPath)) { | ||
| let spectrum = fs.readFileSync(spectrumPath, 'utf8'); | ||
| spectrum = removeImporantComments(targetHost(spectrum)); |
There was a problem hiding this comment.
Suggested change
| spectrum = removeImporantComments(targetHost(spectrum)); | |
| spectrum = removeImportantComments(targetHost(spectrum)); |
Small spelling note ^
There was a problem hiding this comment.
Oh question - I'm assuming this function removes the copyright which you're also adding to files - why not just keep the copyright and strip duplicates after merge? The postcss-discard-comments plugin offers a removeAllButFirst option which is a nice way to preserve the first copyright in the file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces changes to the Spectrum Web Components (SWC) project to facilitate the transition from Spectrum 1 (S1) to Spectrum 2 (S2) CSS. It includes the addition of a new index file
(component/{bridge,spectrum,express}/index.css)in the@spectrum-css/tokens@14.1.0-alpha.3package to assist in loading component-specific CSS. Additionally, it updates the SWC library to process the bridge file (referred to as legacy-overrides in SWC for now) and import it into the components.Changes Made
1.
@spectrum-cssadded a new bridge file in the@spectrum-css/tokens@14.1.0-alpha.3package to aid in loading component-specific CSS from the tokens module directly.2. Updated the
generate-tokenscript to include component's system levels inglobal-vars.css3. Updated the
process-spectrumscript to create alegacy-overridecss file from the@spectrum-css/tokens.../bridge.cssNote: Investigated and identified VRT failures due to changes in global CSS tokens in the new
sp-action-buttonfrom the CSS side. For example,--mod-actionbutton-content-color-defaultnow points togray-25instead ofgray-50for the selected state, which might be a breaking change for S1.Questions and Discussions
Next Steps
Ensure there are no breaks to the existing code before merging.
Implement a PR off SWC’s main that swaps out loading bridge tokens from the tokens package instead of the component packages, and ensure there are no regressions.
Motivation and context
This PR is important to bring in S1/Express core tokens with S2 overrides keeping in mind
How has this been tested?
mainbranch should just work as it is !!Screenshots (if appropriate)
Types of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main.